Skip to content

Comments

SNOW-3052213: fix session package management#4088

Merged
sfc-gh-bkogan merged 6 commits intomainfrom
bkogan-debug-packages
Feb 24, 2026
Merged

SNOW-3052213: fix session package management#4088
sfc-gh-bkogan merged 6 commits intomainfrom
bkogan-debug-packages

Conversation

@sfc-gh-bkogan
Copy link
Contributor

@sfc-gh-bkogan sfc-gh-bkogan commented Feb 24, 2026

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3052213

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Due to the server side depending on private members of the Session class, some changes from the previous PR need to be reverted. We need to keep _packages around, it now represents all packages under the _DEFAULT_ARTIFACT_REPOSITORY. Also reverted changing the argument positions of _resolve_packages.

    There was another issue found where if the schema was not selected, the system function would error instead of propagating up. Fixed by explicitly setting the entity.

@sfc-gh-bkogan sfc-gh-bkogan requested review from a team as code owners February 24, 2026 01:13
@sfc-gh-bkogan sfc-gh-bkogan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Feb 24, 2026
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the failing test before merging

@sfc-gh-bkogan sfc-gh-bkogan merged commit 99623bd into main Feb 24, 2026
27 of 28 checks passed
@sfc-gh-bkogan sfc-gh-bkogan deleted the bkogan-debug-packages branch February 24, 2026 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants